Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4168)

Unified Diff: chrome/app/chrome_dll_main.cc

Issue 99126: Mutual exclusion between gconf and the glib main loop. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_pump_glib.cc ('k') | net/proxy/proxy_config_service_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_dll_main.cc
===================================================================
--- chrome/app/chrome_dll_main.cc (revision 14449)
+++ chrome/app/chrome_dll_main.cc (working copy)
@@ -440,15 +440,9 @@
#endif
} else if (process_type.empty()) {
#if defined(OS_LINUX)
- // Glib/GDK type system and threading initializations. Needed at
- // least for gconf usage in net/proxy/proxy_config_service_linux.cc.
- // TODO(sdoyon): confirm whether gconf truly needs this. If so,
- // the GTK main loop (message pump) must also be made to call
- // gdk_threads_enter/leave(). Similar issue with the clipboard
- // (estade@ deanm@).
+ // Glib type system initialization. Needed at least for gconf (in
+ // net/proxy/proxy_config_service_linux.cc).
g_type_init();
- g_thread_init(NULL);
- gdk_threads_init();
// gtk_init() can change |argc| and |argv|, but nobody else uses them.
gtk_init(&argc, const_cast<char***>(&argv));
SetUpGLibLogHandler();
« no previous file with comments | « base/message_pump_glib.cc ('k') | net/proxy/proxy_config_service_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698