Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 99122: Changed the debugger message API to receive an object instead of a JSON string (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changed the debugger message API to receive an object instead of a JSON string. The object delivered to the debug message handler contains additional information on the current break handling the messages. Clients which require just JSON message parsing can simply get the JSON using the GetJSON message on the message object to still have the previous behaviour. NewMessageHangler(const v8::Debug::Message& message) { v8::String::Value val(message.GetJSON()); OldMessageHandler(Vector<uint16_t>(const_cast<uint16_t*>(*val), val.length())); } Refactored some of the debugger code to use internal handles instead of API handles. Also changed Object to JSObject is some places. The access to the active context when the break occurred is still not implemented. I will add this in a new CL, as this one is quite big already. Committed: http://code.google.com/p/v8/source/detail?r=1811

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -117 lines) Patch
M include/v8-debug.h View 1 2 2 chunks +55 lines, -10 lines 0 comments Download
M src/debug.h View 1 2 3 chunks +52 lines, -8 lines 0 comments Download
M src/debug.cc View 1 2 3 16 chunks +148 lines, -63 lines 0 comments Download
M src/debug-agent.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/debug-agent.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 8 chunks +17 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
LGTM http://codereview.chromium.org/99122/diff/1014/1018 File src/debug.cc (right): http://codereview.chromium.org/99122/diff/1014/1018#newcode2087 Line 2087: MessageImpl message(true, event, false, I think value ...
11 years, 8 months ago (2009-04-28 12:00:38 UTC) #1
Christian Plesner Hansen
Lgtm
11 years, 8 months ago (2009-04-28 12:50:28 UTC) #2
Søren Thygesen Gjesse
11 years, 7 months ago (2009-04-29 08:59:28 UTC) #3
http://codereview.chromium.org/99122/diff/1014/1018
File src/debug.cc (right):

http://codereview.chromium.org/99122/diff/1014/1018#newcode2087
Line 2087: MessageImpl message(true, event, false,
On 2009/04/28 12:00:38, Yury Semikhatsky wrote:
> I think value of the 'running' parameter should be passed as a param to the
> method the same way as for responses or retrieved from event_data.

Changed that, so that auto continue events have have running equals true. I need
to work more on this though, as responses to requests processed in this case
will have running state false.

Powered by Google App Engine
This is Rietveld 408576698