Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: webkit/glue/devtools/debugger_agent_impl.cc

Issue 99121: Merge WebKit console and load deferrer changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/devtools/js/devtools.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include <wtf/HashSet.h> 7 #include <wtf/HashSet.h>
8 #include <wtf/RefPtr.h> 8 #include <wtf/RefPtr.h>
9 #include <wtf/Vector.h> 9 #include <wtf/Vector.h>
10 10
11 #include "Document.h" 11 #include "Document.h"
12 #include "Frame.h"
13 #include "Node.h" 12 #include "Node.h"
14 #include "Page.h" 13 #include "Page.h"
15 #include "PageGroup.h" 14 #include "PageGroupLoadDeferrer.h"
16 #undef LOG 15 #undef LOG
17 16
18 #include "grit/webkit_resources.h" 17 #include "grit/webkit_resources.h"
19 #include "V8Binding.h" 18 #include "V8Binding.h"
20 #include "V8DOMWindow.h" 19 #include "V8DOMWindow.h"
21 #include "v8_index.h" 20 #include "v8_index.h"
22 #include "v8_proxy.h" 21 #include "v8_proxy.h"
23 #include "webkit/glue/devtools/debugger_agent_impl.h" 22 #include "webkit/glue/devtools/debugger_agent_impl.h"
24 #include "webkit/glue/devtools/debugger_agent_manager.h" 23 #include "webkit/glue/devtools/debugger_agent_manager.h"
25 #include "webkit/glue/glue_util.h" 24 #include "webkit/glue/glue_util.h"
26 #include "webkit/glue/webdevtoolsagent_impl.h" 25 #include "webkit/glue/webdevtoolsagent_impl.h"
27 #include "webkit/glue/webkit_glue.h" 26 #include "webkit/glue/webkit_glue.h"
28 #include "webkit/glue/webview_impl.h" 27 #include "webkit/glue/webview_impl.h"
29 28
30 using WebCore::DOMWindow; 29 using WebCore::DOMWindow;
31 using WebCore::Document; 30 using WebCore::Document;
32 using WebCore::Frame;
33 using WebCore::Node; 31 using WebCore::Node;
34 using WebCore::Page; 32 using WebCore::Page;
35 using WebCore::PageGroup; 33 using WebCore::PageGroupLoadDeferrer;
36 using WebCore::String; 34 using WebCore::String;
37 using WebCore::V8ClassIndex; 35 using WebCore::V8ClassIndex;
38 using WebCore::V8Custom; 36 using WebCore::V8Custom;
39 using WebCore::V8DOMWindow; 37 using WebCore::V8DOMWindow;
40 using WebCore::V8Proxy; 38 using WebCore::V8Proxy;
41 39
42 DebuggerAgentImpl::DebuggerAgentImpl( 40 DebuggerAgentImpl::DebuggerAgentImpl(
43 WebViewImpl* web_view_impl, 41 WebViewImpl* web_view_impl,
44 DebuggerAgentDelegate* delegate, 42 DebuggerAgentDelegate* delegate,
45 WebDevToolsAgentImpl* webdevtools_agent) 43 WebDevToolsAgentImpl* webdevtools_agent)
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 v8::Handle<v8::Value> res_obj = function->Call( 135 v8::Handle<v8::Value> res_obj = function->Call(
138 context_->Global(), 2, args); 136 context_->Global(), 2, args);
139 137
140 v8::Handle<v8::String> res_json = v8::Handle<v8::String>::Cast(res_obj); 138 v8::Handle<v8::String> res_json = v8::Handle<v8::String>::Cast(res_obj);
141 return WebCore::toWebCoreString(res_json); 139 return WebCore::toWebCoreString(res_json);
142 } 140 }
143 141
144 void DebuggerAgentImpl::RunWithDeferredMessages( 142 void DebuggerAgentImpl::RunWithDeferredMessages(
145 const HashSet<DebuggerAgentImpl*>& agents, 143 const HashSet<DebuggerAgentImpl*>& agents,
146 WebDevToolsAgent::MessageLoopDispatchHandler handler) { 144 WebDevToolsAgent::MessageLoopDispatchHandler handler) {
147 145 Vector<PageGroupLoadDeferrer*> deferrers;
148 // TODO(pfeldman): Make PageGroupLoadDeferrer visible and use it from here.
149 // Code below is derived from the Chrome.cpp's PageGroupLoadDeferrer:
150 // 1. Disable active objects and input events. 146 // 1. Disable active objects and input events.
151 Vector<RefPtr<Frame>, 16> deferred_frames;
152 for (HashSet<DebuggerAgentImpl*>::const_iterator ag_it = agents.begin(); 147 for (HashSet<DebuggerAgentImpl*>::const_iterator ag_it = agents.begin();
153 ag_it != agents.end(); ++ag_it) { 148 ag_it != agents.end(); ++ag_it) {
154 DebuggerAgentImpl* agent = *ag_it; 149 DebuggerAgentImpl* agent = *ag_it;
150 deferrers.append(new PageGroupLoadDeferrer(agent->GetPage(), true));
155 agent->web_view()->SetIgnoreInputEvents(true); 151 agent->web_view()->SetIgnoreInputEvents(true);
156 const HashSet<Page*>& pages = agent->GetPage()->group().pages();
157 HashSet<Page*>::const_iterator end = pages.end();
158 for (HashSet<Page*>::const_iterator it = pages.begin(); it != end; ++it) {
159 Page* other_page = *it;
160 if (!other_page->defersLoading()) {
161 deferred_frames.append(other_page->mainFrame());
162 #if !PLATFORM(MAC)
163 for (Frame* frame = other_page->mainFrame(); frame;
164 frame = frame->tree()->traverseNext()) {
165 frame->document()->suspendActiveDOMObjects();
166 }
167 #endif
168 }
169 }
170 } 152 }
171 153
172 // 2. Disable loading. 154 // 2. Process messages.
173 size_t count = deferred_frames.size();
174 for (size_t i = 0; i < count; ++i) {
175 if (Page* page = deferred_frames[i]->page()) {
176 page->setDefersLoading(true);
177 }
178 }
179 // 3. Process messages.
180 handler(); 155 handler();
181 156
182 // 4. Bring things back. 157 // 3. Bring things back.
183 for (size_t i = 0; i < deferred_frames.size(); ++i) {
184 if (Page* page = deferred_frames[i]->page()) {
185 page->setDefersLoading(false);
186
187 #if !PLATFORM(MAC)
188 for (Frame* frame = page->mainFrame(); frame; frame =
189 frame->tree()->traverseNext()) {
190 frame->document()->resumeActiveDOMObjects();
191 }
192 #endif
193 }
194 }
195
196 for (HashSet<DebuggerAgentImpl*>::const_iterator ag_it = agents.begin(); 158 for (HashSet<DebuggerAgentImpl*>::const_iterator ag_it = agents.begin();
197 ag_it != agents.end(); ++ag_it) { 159 ag_it != agents.end(); ++ag_it) {
198 (*ag_it)->web_view()->SetIgnoreInputEvents(false); 160 (*ag_it)->web_view()->SetIgnoreInputEvents(false);
199 } 161 }
162 deleteAllValues(deferrers);
200 } 163 }
201 164
202 WebCore::Page* DebuggerAgentImpl::GetPage() { 165 WebCore::Page* DebuggerAgentImpl::GetPage() {
203 return web_view_impl_->page(); 166 return web_view_impl_->page();
204 } 167 }
OLDNEW
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/devtools/js/devtools.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698