Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: webkit/glue/chrome_client_impl.cc

Issue 99121: Merge WebKit console and load deferrer changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/chrome_client_impl.h ('k') | webkit/glue/devtools/debugger_agent_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 8
9 MSVC_PUSH_WARNING_LEVEL(0); 9 MSVC_PUSH_WARNING_LEVEL(0);
10 #include "Console.h"
10 #include "Cursor.h" 11 #include "Cursor.h"
11 #include "FloatRect.h" 12 #include "FloatRect.h"
12 #include "FileChooser.h" 13 #include "FileChooser.h"
13 #include "FrameLoadRequest.h" 14 #include "FrameLoadRequest.h"
14 #include "FrameView.h" 15 #include "FrameView.h"
15 #include "HitTestResult.h" 16 #include "HitTestResult.h"
16 #include "IntRect.h" 17 #include "IntRect.h"
17 #include "Page.h" 18 #include "Page.h"
18 #include "PopupMenuChromium.h" 19 #include "PopupMenuChromium.h"
19 #include "ScriptController.h" 20 #include "ScriptController.h"
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 } 266 }
266 267
267 bool ChromeClientImpl::menubarVisible() { 268 bool ChromeClientImpl::menubarVisible() {
268 return menubar_visible_; 269 return menubar_visible_;
269 } 270 }
270 271
271 void ChromeClientImpl::setResizable(bool value) { 272 void ChromeClientImpl::setResizable(bool value) {
272 resizable_ = value; 273 resizable_ = value;
273 } 274 }
274 275
275 void ChromeClientImpl::addMessageToConsole(const WebCore::String& message, 276 void ChromeClientImpl::addMessageToConsole(WebCore::MessageSource source,
277 WebCore::MessageLevel level,
278 const WebCore::String& message,
276 unsigned int line_no, 279 unsigned int line_no,
277 const WebCore::String& source_id) { 280 const WebCore::String& source_id) {
278 WebViewDelegate* delegate = webview_->delegate(); 281 WebViewDelegate* delegate = webview_->delegate();
279 if (delegate) { 282 if (delegate) {
280 std::wstring wstr_message = webkit_glue::StringToStdWString(message); 283 std::wstring wstr_message = webkit_glue::StringToStdWString(message);
281 std::wstring wstr_source_id = webkit_glue::StringToStdWString(source_id); 284 std::wstring wstr_source_id = webkit_glue::StringToStdWString(source_id);
282 delegate->AddMessageToConsole(webview_, wstr_message, 285 delegate->AddMessageToConsole(webview_, wstr_message,
283 line_no, wstr_source_id); 286 line_no, wstr_source_id);
284 } 287 }
285 WebDevToolsAgentImpl* devtools_agent = webview_->GetWebDevToolsAgentImpl(); 288 WebDevToolsAgentImpl* devtools_agent = webview_->GetWebDevToolsAgentImpl();
286 if (devtools_agent) { 289 if (devtools_agent) {
287 devtools_agent->AddMessageToConsole(message, source_id, line_no); 290 devtools_agent->AddMessageToConsole(source, level, message, line_no, source_ id);
288 } 291 }
289 } 292 }
290 293
291 bool ChromeClientImpl::canRunBeforeUnloadConfirmPanel() { 294 bool ChromeClientImpl::canRunBeforeUnloadConfirmPanel() {
292 return webview_->delegate() != NULL; 295 return webview_->delegate() != NULL;
293 } 296 }
294 297
295 bool ChromeClientImpl::runBeforeUnloadConfirmPanel( 298 bool ChromeClientImpl::runBeforeUnloadConfirmPanel(
296 const WebCore::String& message, 299 const WebCore::String& message,
297 WebCore::Frame* frame) { 300 WebCore::Frame* frame) {
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 // EventHandler.cpp and since we don't want that we set a flag indicating 588 // EventHandler.cpp and since we don't want that we set a flag indicating
586 // that the next SetCursor call is to be ignored. 589 // that the next SetCursor call is to be ignored.
587 ignore_next_set_cursor_ = true; 590 ignore_next_set_cursor_ = true;
588 } 591 }
589 592
590 void ChromeClientImpl::formStateDidChange(const WebCore::Node*) { 593 void ChromeClientImpl::formStateDidChange(const WebCore::Node*) {
591 WebViewDelegate* delegate = webview_->delegate(); 594 WebViewDelegate* delegate = webview_->delegate();
592 if (delegate) 595 if (delegate)
593 delegate->OnNavStateChanged(webview_); 596 delegate->OnNavStateChanged(webview_);
594 } 597 }
OLDNEW
« no previous file with comments | « webkit/glue/chrome_client_impl.h ('k') | webkit/glue/devtools/debugger_agent_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698