Issue 99120: Inline the inobject property case for named property loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99120: Inline the inobject property case for named property loads. (Closed)

Created:
11 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Inline the inobject property case for named property loads. Committed: http://code.google.com/p/v8/source/detail?r=1806

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -37 lines)			Patch
M	src/codegen.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	4 chunks	+102 lines, -10 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View		1 chunk	+48 lines, -18 lines	1 comment	Download
M	src/ic.h	View	1	4 chunks	+12 lines, -4 lines	0 comments	Download
M	src/ic.cc	View		4 chunks	+28 lines, -2 lines	0 comments	Download
M	src/v8-counters.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

This will need a fix to the debugger, analogous to the inlined keyed loads.

11 years, 8 months ago (2009-04-28 08:41:21 UTC) #1

Kasper Lund

LGTM. It would be great to get some measurements on code size impact for real ...

11 years, 8 months ago (2009-04-28 09:03:51 UTC) #2

Mads Ager (chromium)

11 years, 8 months ago (2009-04-28 09:53:54 UTC) #3

LGTM

http://codereview.chromium.org/99120/diff/1003/1005
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/99120/diff/1003/1005#newcode755
Line 755: // The delta to the start of the map chack instruction.
chack -> check.

Expand Messages | Collapse Messages