Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/test/reliability/page_load_test.cc

Issue 99118: Fix PageLoadTest.Reliability which I broke in my previous checkin to make the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/reliability/page_load_test.cc
===================================================================
--- chrome/test/reliability/page_load_test.cc (revision 14717)
+++ chrome/test/reliability/page_load_test.cc (working copy)
@@ -338,17 +338,13 @@
// Go to "about:crash"
NavigateToURLLogResult(GURL(crash_url), log_file, &metrics);
- // Page load crashed and test automation timed out.
- EXPECT_EQ(NAVIGATION_TIME_OUT, metrics.result);
// Found a crash dump
EXPECT_EQ(1, metrics.crash_dump_count) << kFailedNoCrashService;
// Browser did not crash, and exited cleanly.
EXPECT_EQ(true, metrics.browser_clean_exit);
EXPECT_EQ(1, metrics.browser_launch_count);
- // Only starting page was loaded.
- EXPECT_EQ(1, metrics.page_load_count);
+ // Only the renderer should have crashed.
EXPECT_EQ(0, metrics.browser_crash_count);
- // Renderer crashed.
EXPECT_EQ(1, metrics.renderer_crash_count);
EXPECT_EQ(0, metrics.plugin_crash_count);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698