Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 99118: Fix PageLoadTest.Reliability which I broke in my previous checkin to make the... (Closed)

Created:
11 years, 8 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix PageLoadTest.Reliability which I broke in my previous checkin to make the throbber more responsive. The issue is that I changed the meaning of LOAD_START from indicating that the renderer started loading to indicating when the browser told the renderer to start loading. This means it now looks like we started loading "about:crash" whereas before it didn't. I think this change is reasonable and how we could about:crash in this respect isn't important, so I just removed the failing checks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
11 years, 8 months ago (2009-04-28 08:08:45 UTC) #1
TBR

Powered by Google App Engine
This is Rietveld 408576698