media player wtl_render - video renderer

media player wtl_render - video renderer


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14922

[fbarchard, 2009-04-28 06:02:22]

A tiny file, since its almost entirely using base renderer, and view.h does the
real work.
I've removed the timing code to keep it simple.

[fbarchard, 2009-04-29 18:57:55]

review me!  I'm tiny.

[Alpha Left Google, 2009-04-29 19:04:08]

http://codereview.chromium.org/99117/diff/1016/1017
File media/player/wtl_renderer.cc (right):

http://codereview.chromium.org/99117/diff/1016/1017#newcode7
Line 7: #include "media/player/view.h"
order includes.

http://codereview.chromium.org/99117/diff/1016/1017#newcode10
Line 10: : window_(window) {
indent by 4 chars before :

http://codereview.chromium.org/99117/diff/1016/1017#newcode22
Line 22: void
WtlVideoRenderer::GetCurrentFrame(scoped_refptr<media::VideoFrame>*
"scoped_refptr<media::VideoFrame>* frame_out" in on line below, indent by 4
spaces.

http://codereview.chromium.org/99117/diff/1016/1018
File media/player/wtl_renderer.h (right):

http://codereview.chromium.org/99117/diff/1016/1018#newcode5
Line 5: // Video renderer for media player
period at the end of line.

http://codereview.chromium.org/99117/diff/1016/1018#newcode21
Line 21: static bool IsMediaFormatSupported(const media::MediaFormat &format) {
const media::MediaFormat& format

[fbarchard, 2009-04-29 23:17:06]

look good yet?

http://codereview.chromium.org/99117/diff/1016/1017
File media/player/wtl_renderer.cc (right):

http://codereview.chromium.org/99117/diff/1016/1017#newcode7
Line 7: #include "media/player/view.h"
order sensitive.  I can remove wtl_renderer.h and have view.h include it... will
try that and see what you think.
Done

http://codereview.chromium.org/99117/diff/1016/1017#newcode10
Line 10: : window_(window) {
On 2009/04/29 19:04:08, Alpha wrote:
> indent by 4 chars before :

Done.

http://codereview.chromium.org/99117/diff/1016/1017#newcode22
Line 22: void
WtlVideoRenderer::GetCurrentFrame(scoped_refptr<media::VideoFrame>*
On 2009/04/29 19:04:08, Alpha wrote:
> "scoped_refptr<media::VideoFrame>* frame_out" in on line below, indent by 4
> spaces.

This is why I brought up the 80 column standard. :-)

Done.

http://codereview.chromium.org/99117/diff/1016/1018
File media/player/wtl_renderer.h (right):

http://codereview.chromium.org/99117/diff/1016/1018#newcode5
Line 5: // Video renderer for media player
On 2009/04/29 19:04:08, Alpha wrote:
> period at the end of line.

Done.

http://codereview.chromium.org/99117/diff/1016/1018#newcode21
Line 21: static bool IsMediaFormatSupported(const media::MediaFormat &format) {
On 2009/04/29 19:04:08, Alpha wrote:
> const media::MediaFormat& format

Done.

[Alpha Left Google, 2009-04-30 00:29:36]

LGTM.