Refactored the CloudPolicyProvider so that it becomes initialized once and stays initialized.

chrome/browser/chromeos/login/login_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/time.h"
 #include "chrome/browser/chromeos/cros/cros_in_process_browser_test.h"
 #include "chrome/browser/chromeos/cros/mock_cryptohome_library.h"
 #include "chrome/browser/chromeos/cros/mock_library_loader.h"
 #include "chrome/browser/chromeos/cros/mock_network_library.h"
@@ skipping 16 matching lines @@
   }
 
  protected:
   virtual void SetUpInProcessBrowserTestFixture() {
     cros_mock_->InitStatusAreaMocks();
     cros_mock_->SetStatusAreaMocksExpectations();
     cros_mock_->InitMockCryptohomeLibrary();
     mock_cryptohome_library_ = cros_mock_->mock_cryptohome_library();
     EXPECT_CALL(*mock_cryptohome_library_, IsMounted())
         .WillRepeatedly(Return(true));
+    EXPECT_CALL(*mock_cryptohome_library_, InstallAttributesIsReady())
+        .WillRepeatedly(Return(false));

[Mattias Nissler (ping if slow), 2012/03/30 08:48:46]

and this? It seems like the more reasonable choice would be to return true.

[Joao da Silva, 2012/03/30 10:09:23]

Same reason. Returning false is more straightforward, since returning true will
require a couple more expected calls; but since device policy doesn't matter for
these tests, returning false suffices.

[Mattias Nissler (ping if slow), 2012/03/30 11:46:35]

Hm. In that case, why do we enable the flags for all tests? Is there away to
just enable them for the tests that actually need them?

   }
 
   MockCryptohomeLibrary* mock_cryptohome_library_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(LoginTestBase);
 };
 
 class LoginUserTest : public LoginTestBase {
  protected:
@@ skipping 28 matching lines @@
 // On initial launch, we should get the OTR default profile.
 IN_PROC_BROWSER_TEST_F(LoginProfileTest, UserNotPassed) {
   Profile* profile = browser()->profile();
   EXPECT_EQ("Default", profile->GetPath().BaseName().value());
   EXPECT_TRUE(profile->IsOffTheRecord());
   // Ensure there's extension service for this profile.
   EXPECT_TRUE(profile->GetExtensionService());
 }
 
 } // namespace chromeos