Fix SlideAnimatorGtk::OpenWithoutAnimation()....

Fix SlideAnimatorGtk::OpenWithoutAnimation().

We weren't sizing the GtkFixed widget because the animation delegate callbacks weren't being called. Now we artificially call AnimationProgressed() once we know what size the GtkFixed should be.

TEST=switching back to a tab that has an infobar open should properly display that infobar.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14893

[Evan Stade, 2009-04-28 00:56:52]

as commented in the constructor,

"The size of the GtkFixed widget is set during animation. When we open without
showing the animation, we have to call AnimationProgressed ourselves to properly
set the size of the GtkFixed. We can't do this until after the child has been
allocated, hence we connect to "size-allocate" on the child."

[Evan Stade, 2009-04-28 01:00:48]

adding reviewers this time.

[Dean McNamee, 2009-04-28 08:33:42]

Yeah... ok.

Can you fix the description, "Fix" is not super descriptive.  Can you say what
the problem was and how you fixed it?

Thanks

http://codereview.chromium.org/99110/diff/1/2
File chrome/browser/gtk/slide_animator_gtk.cc (right):

http://codereview.chromium.org/99110/diff/1/2#newcode14
Line 14: GtkAllocation* allocation,
indention

http://codereview.chromium.org/99110/diff/1/2#newcode101
Line 101: GtkAllocation* allocation, SlideAnimatorGtk* slider) {
can these fit vertically?

http://codereview.chromium.org/99110/diff/1/3
File chrome/browser/gtk/slide_animator_gtk.h (right):

http://codereview.chromium.org/99110/diff/1/3#newcode68
Line 68: GtkAllocation* allocation, SlideAnimatorGtk* slider);
can you line these up vertically?

http://codereview.chromium.org/99110/diff/1/3#newcode86
Line 86: // is received by |child_|. See comment in SlideAnimatorGtk
constructor.
See the comment

[Evan Stade, 2009-04-28 17:58:10]

done, done, done, done, and done

[Evan Stade, 2009-04-29 21:16:22]

ping

[Evan Martin, 2009-04-29 21:18:20]

LG