Add descriptive text for omnibox popup result items....

Add descriptive text for omnibox popup result items.

Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.

Back to using system colors. Adds highlight icons.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14826

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14873

[Peter Kasting, 2009-04-28 00:01:35]

http://codereview.chromium.org/99102/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/99102/diff/1/2#newcode203
Line 203: <message name="IDS_AUTOCOMPLETE_MATCH_DESCRIPTION_SEPARTOR" desc="The
separator between a result in the autocomplete popup and its description.">
Can't do this, for i18n reasons.  Have to do something like "$1 - $2".  This
will make the drawing code more complex, unfortunately.

P.S. You spelled it SEPARTOR.

http://codereview.chromium.org/99102/diff/1/3
File chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/99102/diff/1/3#newcode25
Line 25: static const SkColor kBackgroundColor = SK_ColorWHITE;
r- on non-system colors.  This is not shippable.  Glen's evil UI overlords can
fight me :)

[Ben Goodger (Google), 2009-04-28 19:55:27]

Back to using system colors.

On 2009/04/28 00:01:35, pkasting wrote:
> Can't do this, for i18n reasons.  Have to do something like "$1 - $2".  This
> will make the drawing code more complex, unfortunately.

This will require modifying the classifications for the description. I was
hoping to defer this until all of the rest of the presentation was in place, and
then have the provider supply the " - " as well and classify it at the same time
its classifying everything else, because its hard to modify the classifications
in this code because of how everything is const :-P Once the modifications to
the provider have been made, I would just remove this code from here.

[Peter Kasting, 2009-04-28 21:34:42]

LGTM as-is, feel free to have me do the i18n changes if you want