Issue 9910010: Fix some grammatical errors in comments in tools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9910010: Fix some grammatical errors in comments in tools/ (Closed)

Created:
8 years, 8 months ago by gavinp

Modified:
8 years, 8 months ago

Reviewers:
asanka

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some grammatical errors in comments in tools/ BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130359

Patch Set 1 #

Total comments: 1

Patch Set 2 : remediate to review #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	tools/dromaeo_benchmark_runner/dromaeo_benchmark_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/measure_page_load_time/ie_bho/MeasurePageLoadTimeBHO.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/playback_benchmark/playback.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/traceline/svgui/traceline.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/traceline/traceline/syscall_map.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gavinp

I found I had one more of these to upload! Whoops! Asanka, wdyt?

8 years, 8 months ago (2012-03-29 15:31:02 UTC) #1

asanka

8 years, 8 months ago (2012-03-29 16:28:04 UTC) #2

LGTM :)

http://codereview.chromium.org/9910010/diff/1/tools/measure_page_load_time/ie...
File tools/measure_page_load_time/ie_bho/MeasurePageLoadTimeBHO.h (right):

http://codereview.chromium.org/9910010/diff/1/tools/measure_page_load_time/ie...
tools/measure_page_load_time/ie_bho/MeasurePageLoadTimeBHO.h:19: #error
"Single-threaded COM objects are not properly supported on Windows CE platform,
such as the Windows Mobile platforms that do not include full DCOM support.
Define _CE_ALLOW_SINGLE_THREADED_OBJECTS_IN_MTA to force ATL to support creating
single-thread COM object's and allow use of its single-threaded COM object
implementations. The threading model in your rgs file was set to 'Free' as that
is the only threading model supported in non DCOM Windows CE platforms."
"object's" -> "objects"

Expand Messages | Collapse Messages