chrome/test/data/extensions/api_test/accessible_cer/manifest.json - Issue 9909019: Add schema chrome-extension-resource:// for extension resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/accessible_cer/manifest.json

Issue 9909019: Add schema chrome-extension-resource:// for extension resources (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add tests Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/extensions/extension_resource_request_policy.cc ('K') | « chrome/test/data/extensions/api_test/accessible_cer/main.html ('k') | chrome/test/data/extensions/api_test/extension_resource_request_policy/web_accessible/nonaccessabile_chrome_resource_scheme.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "Access chrome-extension-resource:// test",

	3 "version": "0.1",

	4 "manifest_version": 2,
	Aaron Boodman 2012/04/16 18:56:15 We should make the default security policy for man We should make the default security policy for manifest_version=2 allow chrome-resource://. Peng 2012/04/17 13:52:05 Done. Show quoted text On 2012/04/16 18:56:15, Aaron Boodman wrote: > We should make the default security policy for manifest_version=2 allow > chrome-resource://. Done.
	5 "description": "Access chrome-extension-resource:// test",

	6 "platform_app": true,

	7 "app": {

	8 "launch": {

	9 "container": "shell",

	10 "local_path": "main.html",

	11 "width": 100,

	12 "height": 100

	13 }

	14 },

	15 "permissions": [

	16 "experimental",

	17 "chrome-extension-resource://analytics"
	Aaron Boodman 2012/04/16 18:54:36 We don't need a permission for this. Also, perhaps We don't need a permission for this. Also, perhaps it would be better to use just chrome-resource for the scheme, to not couple it to extensions. Aaron Boodman 2012/04/16 18:56:15 Actually, I don't see this getting checked anywher Show quoted text On 2012/04/16 18:54:36, Aaron Boodman wrote: > We don't need a permission for this. Also, perhaps it would be better to use > just chrome-resource for the scheme, to not couple it to extensions. Actually, I don't see this getting checked anywhere in the patch. Is it just old test data that didn't get removed? Peng 2012/04/17 13:52:05 Done. Show quoted text On 2012/04/16 18:56:15, Aaron Boodman wrote: > On 2012/04/16 18:54:36, Aaron Boodman wrote: > > We don't need a permission for this. Also, perhaps it would be better to use > > just chrome-resource for the scheme, to not couple it to extensions. > > Actually, I don't see this getting checked anywhere in the patch. Is it just old > test data that didn't get removed? Done.
	18 ],

	19 "content_security_policy": "script-src 'self' chrome-extension-resource://anal ytics; object-src 'self'"

	20 }

OLD	NEW