Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 99090: Add a hook for using the std::set_new_handler().... (Closed)

Created:
11 years, 8 months ago by Mike Belshe
Modified:
9 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a hook for using the std::set_new_handler(). This is what tcmalloc uses to hook out-of-memory cases. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14847

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 2 chunks +2 lines, -9 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Mike Belshe
Running through try-servers to see if this effects other platforms. May need platform specific changes, ...
11 years, 8 months ago (2009-04-27 23:00:26 UTC) #1
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/99090/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/99090/diff/1/2#newcode124 Line 124: 1- we have the same stuff in line ...
11 years, 8 months ago (2009-04-28 00:38:37 UTC) #2
cpu_(ooo_6.6-7.5)
11 years, 7 months ago (2009-04-28 22:38:16 UTC) #3
LGTM, but see my comment below.

http://codereview.chromium.org/99090/diff/3/1005
File chrome/app/chrome_dll_main.cc (left):

http://codereview.chromium.org/99090/diff/3/1005#oldcode198
Line 198: _set_new_mode(1);
why is _set_new_mode(1) gone?

Powered by Google App Engine
This is Rietveld 408576698