Issue 99088: Style fixes for previous review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99088: Style fixes for previous review (Closed)

Created:
11 years, 8 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Style fixes for previous review: http://codereview.chromium.org/92062 I didn't make WebMenuRunner's menu_ a scoped_nsobject, because I'm not sure how that will ever be released (~scoped_nsobject won't get called from a Cocoa object's dealloc?). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14798

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 2

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -48 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2 3 4 5 6 7	1 chunk	+7 lines, -6 lines	0 comments	Download
M	webkit/glue/webmenurunner_mac.h	View	1 2 3 4 5 6 7	4 chunks	+14 lines, -20 lines	0 comments	Download
M	webkit/glue/webmenurunner_mac.mm	View	1 2 3 4 5 6 7 8	5 chunks	+25 lines, -15 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_webview_delegate.mm	View	1 2 3 4 5 6 7	3 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

11 years, 8 months ago (2009-04-28 13:29:19 UTC) #2

LGTM with fixes below.

http://codereview.chromium.org/99088/diff/25/27
File webkit/glue/webmenurunner_mac.h (right):

http://codereview.chromium.org/99088/diff/25/27#newcode24
Line 24: NSMenu* menu_;
i'd still make this a scoped_nsobject

http://codereview.chromium.org/99088/diff/25/26
File webkit/glue/webmenurunner_mac.mm (right):

http://codereview.chromium.org/99088/diff/25/26#newcode93
Line 93: NSEvent* CreateEventForMenuAction(BOOL item_chosen, int window_num,
This shouldn't be called "Create" because the NSEvent it returns is
autoreleased. The "Create" pattern in CoreFoundation says that the caller is
responsible for releasing anything it gets back from a CreateFoo call, and
that's not the case here. I'd rename the function.

Expand Messages | Collapse Messages