Issue 99085: Swap NOTIMPLEMENTED with a bug comment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99085: Swap NOTIMPLEMENTED with a bug comment. (Closed)

Created:
11 years, 8 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Swap NOTIMPLEMENTED with a bug comment. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14726

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/cocoa/find_bar_bridge.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 8 months ago (2009-04-27 22:05:53 UTC) #2

LGTM

StopAnimation() and RestoreSavedFocus() also get called once per tab switch. 
Should we file bugs for those?  Or just have one bug to finish all of the find
bar work?

GetDialogPosition() and SetDialogPosition() also have NOTIMPLEMENTED()s, but
those are called much more rarely.

Expand Messages | Collapse Messages