depot_tools/presubmit.py - Issue 99072: Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRE...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: depot_tools/presubmit.py

Issue 99072: Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRE... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/

Patch Set: Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: depot_tools/presubmit.py

===================================================================

--- depot_tools/presubmit.py (revision 14622)

+++ depot_tools/presubmit.py (working copy)

@@ -6,7 +6,7 @@

"""Enables directory-specific presubmit checks to run at upload and/or commit.

"""

-__version__ = '1.0'

+__version__ = '1.0.1'

# TODO(joi) Add caching where appropriate/needed. The API is designed to allow

# caching (between all different invocations of presubmit scripts for a given

@@ -629,7 +629,8 @@

for filename in presubmit_files:

if verbose:

print "Running %s" % filename

- presubmit_script = gcl.ReadFile(filename)

+ # Accept CRLF presubmit script.

+ presubmit_script = gcl.ReadFile(filename, 'Ur')

results += executer.ExecPresubmitScript(presubmit_script, filename)

errors = []

« no previous file with comments | « depot_tools/gcl.py ('k') | depot_tools/tests/presubmit_unittest.py » ('j') | no next file with comments »