Issue 9906002: Fix some grammar in chrome/browser/resources/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9906002: Fix some grammar in chrome/browser/resources/ (Closed)

Created:
8 years, 9 months ago by gavinp

Modified:
8 years, 8 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some grammar in chrome/browser/resources/ BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130359

Patch Set 1 #

Total comments: 1

Patch Set 2 : version for landing #

Patch Set 3 : merge to trunk #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	chrome/browser/net/sqlite_persistent_cookie_store_perftest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/sqlite_server_bound_cert_store_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_handler.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/bubble.js	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options2/browser_options.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/language_options.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

8 years, 8 months ago (2012-03-30 18:52:07 UTC) #2

LGTM with fix.

https://chromiumcodereview.appspot.com/9906002/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/language_options.js (right):

https://chromiumcodereview.appspot.com/9906002/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/language_options.js:585: // Don't allow
removing the language if it's an UI language.
s/an/a/

Expand Messages | Collapse Messages