Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 99054: TickProcessor script reimplemented in JavaScript. (Closed)

Created:
11 years, 8 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

TickProcessor script reimplemented in JavaScript. This is an effort to reuse profiler data processing code both in TickProcessor and Dev Tools Profiler. The old Python implementation will be removed. The new TickProcessor works almost identical to the previous one. However, it has some differences: 1. Not very useful "Call profile" section is replaced with a new WebKit-like "Bottom up (heavy) profile" which shows the most expensive functions together with their callers. I used it personally in order to find and remove bottlenecks in the tickprocessor script itself, and found it quite helpful. 2. Code entries with duplicate names (they occur for RegExes, stubs and sometimes for anonymous Function objects) are now distinguished by adding an occurence number inside curly brackets. 3. (Address -> code entry) mapping is more precise in boundary cases. 4. Windows version no more requires specifying .map file location. 5. Works faster. Committed: http://code.google.com/p/v8/source/detail?r=1802

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed 80-chars overflows #

Total comments: 4

Patch Set 3 : Addressed Soeren's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+840 lines, -14 lines) Patch
M test/mjsunit/tools/codemap.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/tools/consarray.js View 1 chunk +60 lines, -0 lines 0 comments Download
M test/mjsunit/tools/profile.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/tools/profileview.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/codemap.js View 3 chunks +20 lines, -1 line 0 comments Download
A tools/consarray.js View 1 chunk +93 lines, -0 lines 0 comments Download
A tools/linux-tick-processor View 1 chunk +16 lines, -0 lines 0 comments Download
M tools/profile.js View 1 1 chunk +8 lines, -6 lines 0 comments Download
M tools/profileview.js View 1 chunk +5 lines, -4 lines 0 comments Download
A tools/tickprocessor.js View 1 2 1 chunk +620 lines, -0 lines 0 comments Download
M tools/tickprocessor.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/windows-tick-processor.bat View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 8 months ago (2009-04-27 12:42:21 UTC) #1
Søren Thygesen Gjesse
LGTM I am looking forward to trying this out! http://codereview.chromium.org/99054/diff/1/7 File tools/consarray.js (right): http://codereview.chromium.org/99054/diff/1/7#newcode74 Line ...
11 years, 8 months ago (2009-04-27 13:29:29 UTC) #2
Mikhail Naganov
11 years, 8 months ago (2009-04-27 13:49:52 UTC) #3
http://codereview.chromium.org/99054/diff/1001/36
File tools/tickprocessor.js (right):

http://codereview.chromium.org/99054/diff/1001/36#newcode57
Line 57: this.cppEntriesProvider = cppEntriesProvider;
On 2009/04/27 13:29:29, Søren Gjesse wrote:
> Trailing underscores?

Done.

http://codereview.chromium.org/99054/diff/1001/36#newcode295
Line 295: function(name) { return self.isSharedLibrary(name); },
On 2009/04/27 13:29:29, Søren Gjesse wrote:
> Indent two more.

Done.

Powered by Google App Engine
This is Rietveld 408576698