Issue 99053: Reverting 14597,14596,14595.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99053: Reverting 14597,14596,14595. (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 14597,14596,14595. The Windows builder ended up building, but the Linux and Mac builds could not compile - not even when clobbered. This is the last lines from the build log: Looks as if the changed directories for the architecture specific files did not find their ways into the builds. TBR=ager@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14598

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1552 lines, -1544 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.sln	View	24 chunks	+1346 lines, -1342 lines	0 comments	Download
M	net/net.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/webkit.sln	View	5 chunks	+203 lines, -199 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks Søren!

Expand Messages | Collapse Messages