Issue 9904002: Fix some grammar in tab_strip_model.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9904002: Fix some grammar in tab_strip_model.cc (Closed)

Created:
8 years, 9 months ago by gavinp

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some grammar in tab_strip_model.cc BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130359

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/tabs/tab_strip_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 9 months ago (2012-03-29 03:10:42 UTC) #2

LGTM

On Wed, Mar 28, 2012 at 4:46 PM, <gavinp@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> wdyt?
>
> Description:
> Fix some grammar in tab_strip_model.cc
>
>
> BUG=None
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/9904002/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/tabs/tab_strip_**model.cc
>
>
> Index: chrome/browser/tabs/tab_strip_**model.cc
> diff --git a/chrome/browser/tabs/tab_**strip_model.cc
> b/chrome/browser/tabs/tab_**strip_model.cc
> index beeb23269be27dd96843cfe572243b**fd404957ba..**
> 8ece105621bb67851132da4aec44ef**b4d90088a1 100644
> --- a/chrome/browser/tabs/tab_**strip_model.cc
> +++ b/chrome/browser/tabs/tab_**strip_model.cc
> @@ -562,7 +562,7 @@ void TabStripModel::SetTabPinned(**int index, bool
> pinned) {
>       NOTREACHED();
>       return;
>     }
> -    // Changing the pinned state of an app tab doesn't effect it's
> mini-tab
> +    // Changing the pinned state of an app tab doesn't affect its mini-tab
>     // status.
>     contents_data_[index]->pinned = pinned;
>   } else {
>
>
>

Expand Messages | Collapse Messages