Chromium Code Reviews| Index: chrome/renderer/extensions/schema_generated_bindings.h |
| diff --git a/chrome/renderer/extensions/schema_generated_bindings.h b/chrome/renderer/extensions/schema_generated_bindings.h |
| index 56a31aadef51d5f31f75f79145e7e433f25bbfcb..8fbcdaff850284d7a67dea98c5a6a22b3b40be32 100644 |
| --- a/chrome/renderer/extensions/schema_generated_bindings.h |
| +++ b/chrome/renderer/extensions/schema_generated_bindings.h |
| @@ -11,6 +11,7 @@ |
| #include "chrome/renderer/extensions/chrome_v8_extension.h" |
| class ExtensionDispatcher; |
| +class ExtensionRequestSender; |
| class ChromeV8ContextSet; |
| class ChromeV8Extension; |
|
not at google - send to devlin
2012/03/30 03:14:31
nit that has nothing to do with your change: :sort
koz (OOO until 15th September)
2012/04/03 00:15:17
This class gets deleted in the follow-up, so I'll
|
| @@ -31,15 +32,8 @@ namespace extensions { |
| // SetIconCommon are in separate classes. |
| class SchemaGeneratedBindings : public ChromeV8Extension { |
| public: |
| - explicit SchemaGeneratedBindings(ExtensionDispatcher* extension_dispatcher); |
| - |
| - // Handles a response to an API request. Sets |extension_id|. |
| - static void HandleResponse(const ChromeV8ContextSet& contexts, |
| - int request_id, |
| - bool success, |
| - const std::string& response, |
| - const std::string& error, |
| - std::string* extension_id); |
| + explicit SchemaGeneratedBindings(ExtensionDispatcher* extension_dispatcher, |
|
not at google - send to devlin
2012/03/30 03:14:31
doesn't need to be "explicit" anymore
koz (OOO until 15th September)
2012/04/03 00:15:17
ditto
|
| + ExtensionRequestSender* request_sender); |
| private: |
| v8::Handle<v8::Value> GetExtensionAPIDefinition(const v8::Arguments& args); |
| @@ -63,6 +57,8 @@ class SchemaGeneratedBindings : public ChromeV8Extension { |
| // before sending the request to the browser. |
| v8::Handle<v8::Value> SetIconCommon(const v8::Arguments& args); |
| + ExtensionRequestSender* request_sender_; |
| + |
| DISALLOW_COPY_AND_ASSIGN(SchemaGeneratedBindings); |
| }; |