Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 99011: Fix issue 11006 - any plugin process started by InProcessBrowserTest was... (Closed)

Created:
11 years, 8 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix issue 11006 - any plugin process started by InProcessBrowserTest was using the unit_test executable rather than chrome.exe. This patch repurposes the --renderer-path switch to be --browser-subprocess-path for both plugins and renderers. BUG=11006 TEST=Any InProcessBrowserTest (they all will start at least one renderer). Use NavigateToURL to a URL containing flash, we shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14951

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/browser/plugin_process_host.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 2 3 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tim (not reviewing)
11 years, 8 months ago (2009-04-24 23:40:21 UTC) #1
jcampan
I don't see the InProcbrowserTest class specifying the new parameter. How is it specified to ...
11 years, 8 months ago (2009-04-24 23:49:56 UTC) #2
tim (not reviewing)
Oops! Forgot to include the file in the patch! Also fixed comment. On 2009/04/24 23:49:56, ...
11 years, 8 months ago (2009-04-25 00:14:20 UTC) #3
jcampan
11 years, 8 months ago (2009-04-25 00:30:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698