Port unload_uitest.cc and enable some of the tests on linux....

Port unload_uitest.cc and enable some of the tests on linux.

Make WaitForSingleProcess respect base::kNoTimeout (which is equivalent to INFINITE on windows).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14508

[tony, 2009-04-24 23:23:45]

http://codereview.chromium.org/99008/diff/1/3
File chrome/browser/unload_uitest.cc (right):

http://codereview.chromium.org/99008/diff/1/3#newcode14
Line 14: #include "chrome/views/window/dialog_delegate.h"
You should be able to remove this and use chrome/common/message_box_flags.h
instead.

http://codereview.chromium.org/99008/diff/1/3#newcode146
Line 146: EXPECT_TRUE(automation()->WaitForAppModalDialog(3000));
We need to implement or refactor into common code some methods in
chrome/browser/app_modal_dialog_gtk.cc for these to start working.  It was on my
TODO list, but you've beaten me to it.

[Evan Stade, 2009-04-24 23:32:16]

http://codereview.chromium.org/99008/diff/1/3
File chrome/browser/unload_uitest.cc (right):

http://codereview.chromium.org/99008/diff/1/3#newcode14
Line 14: #include "chrome/views/window/dialog_delegate.h"
On 2009/04/24 23:23:45, tony wrote:
> You should be able to remove this and use chrome/common/message_box_flags.h
> instead.

Done.

http://codereview.chromium.org/99008/diff/1/3#newcode146
Line 146: EXPECT_TRUE(automation()->WaitForAppModalDialog(3000));
On 2009/04/24 23:23:45, tony wrote:
> We need to implement or refactor into common code some methods in
> chrome/browser/app_modal_dialog_gtk.cc for these to start working.  It was on
my
> TODO list, but you've beaten me to it.

you don't have any idea why the renderer process is loitering around after the
browser is gone, do you?

[tony, 2009-04-24 23:36:34]

I'm not sure.  I would try to implement some of the methods in
app_modal_dialog_gtk.cc and maybe it'll start working?

On 2009/04/24 23:32:16, Evan Stade wrote:
> http://codereview.chromium.org/99008/diff/1/3
> File chrome/browser/unload_uitest.cc (right):
> 
> http://codereview.chromium.org/99008/diff/1/3#newcode14
> Line 14: #include "chrome/views/window/dialog_delegate.h"
> On 2009/04/24 23:23:45, tony wrote:
> > You should be able to remove this and use chrome/common/message_box_flags.h
> > instead.
> 
> Done.
> 
> http://codereview.chromium.org/99008/diff/1/3#newcode146
> Line 146: EXPECT_TRUE(automation()->WaitForAppModalDialog(3000));
> On 2009/04/24 23:23:45, tony wrote:
> > We need to implement or refactor into common code some methods in
> > chrome/browser/app_modal_dialog_gtk.cc for these to start working.  It was
on
> my
> > TODO list, but you've beaten me to it.
> 
> you don't have any idea why the renderer process is loitering around after the
> browser is gone, do you?