Let BaseWinUtilTest.FormatMessage pass in Japanese-localized WinXP....

Let BaseWinUtilTest.FormatMessage pass on localized Windows systems.

Originally, BaseWinUtilTest.FormatMessage depends on current system locale,
and fails on many localized systems. This patch makes the test pass on localized
systems by temporarily changing the current thread's locale to US-English
(en-US) during the test.

BUG=11003

[yutak_google.com, 2009-04-24 23:05:30]

A fix for BaseWinUtilTest.FormatMessage. See commit log for
details.

This is my first time to publish a review, so I would be
happy if you tell me any mistakes, suggestions, or anything.

[sky, 2009-04-24 23:15:47]

Do we really want to expand this test for all languages we support? My vote goes
for returning from this test if not in an english locale.

[yutak_google.com, 2009-04-27 18:01:34]

Thank you for your review, and I'm sorry for my late response.

Basically I agree. Extending the code for every language is not
realistic, so limiting the locale to English seems to be reasonable.
However, it is more desirable if the test is run on non-English
environment.

Do you know some API which (temporarily) changes current message
locale? If there is one, changing the locale to English is just
enough. If there's no such API, I think just returning for non-English
locale is the only way.

[sky, 2009-04-27 18:21:12]

Does SPI_SETDEFAULTINPUTLANG work for this?

[yutak_google.com, 2009-04-27 18:49:43]

I think that is for changing keyboard layouts, not messages
(the HKL type represents a handle of a keyboard layout).

I continue to search for a possible API.

[yutak_google.com, 2009-04-27 19:01:53]

SetLocaleInfo may be possible. I'll test it.

[yutak_google.com, 2009-04-27 21:50:44]

Finally I've found SetThreadLocale API for this purpose and written
a new patch using it. Would you review the updated patch?

The test no longer depends on system locale and should be passed on
every system.

[sky, 2009-04-27 21:55:22]

LGTM

[yutak_google.com, 2009-04-27 22:06:19]

Thank you for your review!

I don't have the right to commit, so could you please check in the
change?

[yutak_google.com, 2009-04-28 00:32:25]

Landed in r14685.