Issue 9896003: Fix some grammar in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9896003: Fix some grammar in sync/ (Closed)

Created:
8 years, 9 months ago by gavinp

Modified:
8 years, 8 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some grammar in sync/ BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130359

Patch Set 2 : Resovling --> Resolving #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	sync/engine/conflict_resolver.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
	M	sync/engine/get_commit_ids_command.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

lgtm https://chromiumcodereview.appspot.com/9896003/diff/1/sync/engine/conflict_resolver.cc File sync/engine/conflict_resolver.cc (right): https://chromiumcodereview.appspot.com/9896003/diff/1/sync/engine/conflict_resolver.cc#newcode251 sync/engine/conflict_resolver.cc:251: DVLOG(1) << "Resovling simple conflict, merging nigori nodes: ...

8 years, 9 months ago (2012-03-28 23:37:44 UTC) #2

gavinp

8 years, 8 months ago (2012-03-30 01:21:18 UTC) #3

On 2012/03/28 23:37:44, ncarter wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/9896003/diff/1/sync/engine/conflict_re...
> File sync/engine/conflict_resolver.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9896003/diff/1/sync/engine/conflict_re...
> sync/engine/conflict_resolver.cc:251: DVLOG(1) << "Resovling simple conflict,
> merging nigori nodes: " << entry;
> We could fix the spelling of Resovling here.

Done.

I know it's a DVLOG, but just to be sure we're not asserting in a test on that
output, I give you:

$ git grep '[rR]esovling'
$

Expand Messages | Collapse Messages

Issue 9896003: Fix some grammar in sync/ (Closed)

Description

Patch Set 1 #

Patch Set 2 : Resovling --> Resolving #

Messages