Make the maximize button behave the same for Panels as other windows.

Make the maximize button behave the same for Panels as other windows.

This partly reverts http://codereview.chromium.org/9773009/ and fixes the maximized window frame for Panels.

9773009 was introduced because of some issues with fullscreen always-on-top windows, however it caused more problems than it solved, and managing always-on-top windows appears to be stable with these changes.

BUG=120662
TEST=Panels should be manageable the same as other windows


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129709

[sky, 2012-03-28 23:46:15]

LGTM

I'm mildly nervous about using a class named WorkspaceFoo that isn't actually
associated with the Workspace related classes. Please add a comment to
WorkspaceEventFilter that this class is also used on the TopLevelContainer. Long
term we should move many of these classes out of the workspace directory to make
it clear they are used with code other than the workspace code.

[stevenjb, 2012-03-29 01:37:08]

I took a closer look at WorkspaceEventFilter, and I don't think we need it or
want it for AlwaysOnTopContainer. I added it because I thought that might be a
good place to override the maximize-on-double-click behavior, then left it in
because I thought that would be more consistent (since always-on-top windows
kind of act like they are in the workspace), but really they aren't, so since I
don't think we need it, I think we're better off without it.

[sky, 2012-03-29 15:58:52]

That means no snapping to the grid on dragging. You should make sure that's ok
with Nicholas.

LGTM

[stevenjb, 2012-03-29 16:21:24]

On 2012/03/29 15:58:52, sky wrote:
> That means no snapping to the grid on dragging. You should make sure that's ok
> with Nicholas.
> 
> LGTM

I think to get grid snapping we'd need to use the workspace layout manager as
well as the event filter. I played with that over the weekend but it was pretty
ugly so I bailed on it.

[commit-bot: I haz the power, 2012-03-29 16:21:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9894001/4001

[sky, 2012-03-29 16:57:09]

On Thu, Mar 29, 2012 at 9:21 AM,  <stevenjb@chromium.org> wrote:
> On 2012/03/29 15:58:52, sky wrote:
>>
>> That means no snapping to the grid on dragging. You should make sure
>> that's ok
>> with Nicholas.
>
>
>> LGTM
>
>
> I think to get grid snapping we'd need to use the workspace layout manager
> as
> well as the event filter. I played with that over the weekend but it was
> pretty
> ugly so I bailed on it.

Using the WorkspaceEventFilter would give you snapping to the grid on
drag/resize. You would have to make sure windows are initially sized
to the grid though.

But, the important thing is to talk with Nicholas to make sure he's ok
with this.

  -Scott

[commit-bot: I haz the power, 2012-03-29 23:02:07]

Change committed as 129709