Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: courgette/win32_x86_generator.h

Issue 988002: Fix for bug where 64-bit executables were processed as 32-bit executables.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/ensemble_create.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/win32_x86_generator.h
===================================================================
--- courgette/win32_x86_generator.h (revision 41586)
+++ courgette/win32_x86_generator.h (working copy)
@@ -7,6 +7,7 @@
#ifndef COURGETTE_WIN32_X86_GENERATOR_H_
#define COURGETTE_WIN32_X86_GENERATOR_H_
+#include "base/logging.h"
#include "base/scoped_ptr.h"
#include "courgette/ensemble.h"
@@ -60,8 +61,10 @@
ParseWin32X86PE(old_element_->region().start(),
old_element_->region().length(),
&old_program);
- if (old_parse_status != C_OK)
+ if (old_parse_status != C_OK) {
+ LOG(ERROR) << "Cannot parse as Win32X86PE " << old_element_->Name();
return old_parse_status;
+ }
AssemblyProgram* new_program = NULL;
Status new_parse_status =
@@ -70,6 +73,7 @@
&new_program);
if (new_parse_status != C_OK) {
DeleteAssemblyProgram(old_program);
+ LOG(ERROR) << "Cannot parse as Win32X86PE " << new_element_->Name();
return new_parse_status;
}
« no previous file with comments | « courgette/ensemble_create.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698