Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2923)

Unified Diff: chrome/common/extensions/extension.cc

Issue 9877018: Lazy background page branding: "Transient Background Page". Rename (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 4ef186a58bf4c447068aa6f00017e923e2699dd8..20e6425ced631ab26f96aa98c0762c8e4eb38fce 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -1804,11 +1804,11 @@ bool Extension::LoadBackgroundPersistent(
string16* error) {
Value* background_persistent = NULL;
if (!api_permissions.count(ExtensionAPIPermission::kExperimental) ||
- !manifest_->Get(keys::kBackgroundPersistent, &background_persistent))
+ !manifest_->Get(keys::kBackgroundTransient, &background_persistent))
return true;
if (!background_persistent->IsType(Value::TYPE_BOOLEAN) ||
- !background_persistent->GetAsBoolean(&background_page_persists_)) {
+ !background_persistent->GetAsBoolean(&background_page_is_transient_)) {
*error = ASCIIToUTF16(errors::kInvalidBackgroundPersistent);
Yoyo Zhou 2012/03/28 21:46:51 I think you want to change this error.
Matt Perry 2012/03/28 21:53:14 Good catch.
return false;
}
@@ -2732,7 +2732,7 @@ Extension::Extension(const FilePath& path,
incognito_split_mode_(false),
offline_enabled_(false),
converted_from_user_script_(false),
- background_page_persists_(true),
+ background_page_is_transient_(false),
allow_background_js_access_(true),
manifest_(manifest.release()),
is_storage_isolated_(false),

Powered by Google App Engine
This is Rietveld 408576698