Lazy background page branding: "Transient Background Page". Rename

chrome/common/extensions/extension.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 554 matching lines @@
   }
   bool has_background_page() const {
     return background_url_.is_valid() || !background_scripts_.empty();
   }
   bool allow_background_js_access() const {
     return allow_background_js_access_;
   }
   const std::vector<std::string>& background_scripts() const {
     return background_scripts_;
   }
-  bool background_page_persists() const { return background_page_persists_; }
+  bool background_page_is_transient() const {
+    return background_page_is_transient_;
+  }
   bool has_persistent_background_page() const {
-    return has_background_page() && background_page_persists();
+    return has_background_page() && !background_page_is_transient();
   }
   bool has_lazy_background_page() const {

[Yoyo Zhou, 2012/03/28 21:46:51]

Why not has_transient_background_page?

[Matt Perry, 2012/03/28 21:53:14]

Yeah... a lot of code calls them "lazy background pages", so I'm just going to
give up and leave that as is. I really only care about saying "transient" in
public-facing APIs.

-    return has_background_page() && !background_page_persists();
+    return has_background_page() && background_page_is_transient();
   }
   const GURL& options_url() const { return options_url_; }
   const GURL& devtools_url() const { return devtools_url_; }
   const ExtensionPermissionSet* optional_permission_set() const {
     return optional_permission_set_.get();
   }
   const ExtensionPermissionSet* required_permission_set() const {
     return required_permission_set_.get();
   }
   const GURL& update_url() const { return update_url_; }
@@ skipping 329 matching lines @@
   base::hash_set<std::string> web_accessible_resources_;
 
   // Optional URL to a master page of which a single instance should be always
   // loaded in the background.
   GURL background_url_;
 
   // Optional list of scripts to use to generate a background page. If this is
   // present, background_url_ will be empty and generated by GetBackgroundURL().
   std::vector<std::string> background_scripts_;
 
-  // True if the background page should stay loaded forever; false if it should
-  // load on-demand (when it needs to handle an event). Defaults to true.
-  bool background_page_persists_;
+  // False if the background page should stay loaded forever; true if it should
+  // load on-demand (when it needs to handle an event). Defaults to false.
+  bool background_page_is_transient_;
 
   // True if the background page can be scripted by pages of the app or
   // extension, in which case all such pages must run in the same process.
   // False if such pages are not permitted to script the background page,
   // allowing them to run in different processes.
   bool allow_background_js_access_;
 
   // Optional URL to a page for setting options/preferences.
   GURL options_url_;
 
@@ skipping 148 matching lines @@
   // only contain the removed permissions.
   const ExtensionPermissionSet* permissions;
 
   UpdatedExtensionPermissionsInfo(
       const Extension* extension,
       const ExtensionPermissionSet* permissions,
       Reason reason);
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_