Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 9875027: Close shm in image data destructor (Closed)

Created:
8 years, 9 months ago by nfullagar
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Close shm in image data destructor TEST=try BUG=http://code.google.com/p/chromium/issues/detail?id=120728 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129550

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
lgtm
8 years, 8 months ago (2012-03-28 20:20:55 UTC) #1
dmichael (off chromium)
lgtm Is there any reasonable way to test this (possibly in a future CL)?
8 years, 8 months ago (2012-03-28 20:21:59 UTC) #2
nfullagar
ppapi_browser/ppb_image_data has some tests; can add more in another CL.
8 years, 8 months ago (2012-03-28 20:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/9875027/3002
8 years, 8 months ago (2012-03-28 20:33:57 UTC) #4
dmichael (off chromium)
If it's not too hard to test particularly that we're not leaking handles (or whatever ...
8 years, 8 months ago (2012-03-28 20:33:59 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-03-29 01:40:10 UTC) #6
Change committed as 129550

Powered by Google App Engine
This is Rietveld 408576698