Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: ui/views/controls/combobox/native_combobox_wrapper.h

Issue 9875001: views: Rename Combobox "selected getter/setter" accessors to something more accurate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/combobox/native_combobox_wrapper.h
diff --git a/ui/views/controls/combobox/native_combobox_wrapper.h b/ui/views/controls/combobox/native_combobox_wrapper.h
index f11a2f617e77085baed5400265ee918624ad846d..390cbc9d41d7fef1e187f8ec420022b71ce1e12d 100644
--- a/ui/views/controls/combobox/native_combobox_wrapper.h
+++ b/ui/views/controls/combobox/native_combobox_wrapper.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -24,35 +24,34 @@ class VIEWS_EXPORT NativeComboboxWrapper {
// Updates the combobox's content from its model.
virtual void UpdateFromModel() = 0;
- // Updates the displayed selected item from the associated Combobox.
- virtual void UpdateSelectedItem() = 0;
+ // Updates the selected index from the associated combo box.
+ virtual void UpdateSelectedIndex() = 0;
- // Updates the enabled state of the combobox from the associated view.
+ // Updates the enabled state of the combo box from the associated view.
virtual void UpdateEnabled() = 0;
- // Gets the selected index.
- virtual int GetSelectedItem() const = 0;
+ // Returns the selected index.
+ virtual int GetSelectedIndex() const = 0;
- // Returns true if the Combobox dropdown is open.
+ // Returns true if the combo box dropdown is open.
virtual bool IsDropdownOpen() const = 0;
- // Returns the preferred size of the combobox.
+ // Returns the preferred size of the combo box.
virtual gfx::Size GetPreferredSize() = 0;
- // Retrieves the views::View that hosts the native control.
+ // Retrieves the view that hosts the native control.
virtual View* GetView() = 0;
// Sets the focus to the button.
virtual void SetFocus() = 0;
- // Invoked when a key is pressed/release on Combobox. Subclasser
- // should return true if the event has been processed and false
- // otherwise.
+ // Invoked when a key is pressed/release on combo box. Subclasser should
+ // return true if the event has been processed and false otherwise.
// See also View::OnKeyPressed/OnKeyReleased.
virtual bool HandleKeyPressed(const views::KeyEvent& e) = 0;
virtual bool HandleKeyReleased(const views::KeyEvent& e) = 0;
- // Invoked when focus is being moved from or to the Combobox.
+ // Invoked when focus is being moved from or to the combo box.
// See also View::OnFocus/OnBlur.
virtual void HandleFocus() = 0;
virtual void HandleBlur() = 0;

Powered by Google App Engine
This is Rietveld 408576698