Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 9875001: views: Rename Combobox "selected getter/setter" accessors to something more accurate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 33a287457219e6640cc8aa0c8bfdbf5698cf9ce1..85c2846e665a73bf81bf6738bd84ab7d3f2fe995 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -169,7 +169,7 @@ void BookmarkBubbleView::Init() {
l10n_util::GetStringUTF16(IDS_BOOKMARK_BUBBLE_FOLDER_TEXT));
parent_combobox_ = new views::Combobox(&parent_model_);
- parent_combobox_->SetSelectedItem(parent_model_.node_parent_index());
+ parent_combobox_->SetSelectedIndex(parent_model_.node_parent_index());
parent_combobox_->set_listener(this);
parent_combobox_->SetAccessibleName(combobox_label->text());
@@ -334,9 +334,9 @@ void BookmarkBubbleView::ApplyEdits() {
UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
}
// Last index means 'Choose another folder...'
- if (parent_combobox_->selected_item() < parent_model_.GetItemCount() - 1) {
+ if (parent_combobox_->selected_index() < parent_model_.GetItemCount() - 1) {
const BookmarkNode* new_parent =
- parent_model_.GetNodeAt(parent_combobox_->selected_item());
+ parent_model_.GetNodeAt(parent_combobox_->selected_index());
if (new_parent != node->parent()) {
content::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeParent"));

Powered by Google App Engine
This is Rietveld 408576698