Issue 9874020: Provide a NSAutoreleasePool for the SequencedWorkerPool::Inner::ThreadLoop().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9874020: Provide a NSAutoreleasePool for the SequencedWorkerPool::Inner::ThreadLoop(). (Closed)

Created:
8 years, 9 months ago by Robert Sesek

Modified:
8 years, 8 months ago

Reviewers:
Mark Mentovai, akalin

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Provide a NSAutoreleasePool for the SequencedWorkerPool::Inner::ThreadLoop(). This adds a pool that is drained on every cycle of the thread loop, just like in MessagePumpDefault and MessagePumpLibevent, which mimics the behavior of the system run loops. BUG=120654 TEST=Launch Chromium. See no messages about leaking objects for want of a pool. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129540

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	base/threading/sequenced_worker_pool.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9874020/1

8 years, 9 months ago (2012-03-28 18:23:37 UTC) #4

Change committed as 129540

Expand Messages | Collapse Messages