Issue 9873037: P2P TCP SocketServer changes to allow accept callback object reset before calling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9873037: P2P TCP SocketServer changes to allow accept callback object reset before calling (Closed)

Created:
8 years, 9 months ago by Mallinath (Gone from Chromium)

Modified:
8 years, 8 months ago

Reviewers:
Sergey Ulanov, Alpha Left Google

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Fixing incorrect log message after successful SetSendBufferSize. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129593

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/renderer_host/p2p/socket_host_tcp.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Sergey Ulanov

The change in socket_host_tcp.cc looks good. The problem with accept should be fixed in TCPServerSocket. ...

8 years, 9 months ago (2012-03-28 20:59:38 UTC) #2

Mallinath (Gone from Chromium)

Removed other files, as your CL http://codereview.chromium.org/9837122/ will handle related to TCP server issue. On ...

8 years, 9 months ago (2012-03-28 23:44:18 UTC) #3

Sergey Ulanov

LGTM. Please update the CL description to reflect what this CL is for (i.e. not ...

8 years, 8 months ago (2012-03-29 05:31:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/9873037/6001

8 years, 8 months ago (2012-03-29 05:35:01 UTC) #5

Change committed as 129593