Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 9873028: Make sure password manager does not display at the same time as one-click on (Closed)

Created:
8 years, 9 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 8 months ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Make sure password manager does not display at the same time as one-click on mac and linux now that one-click is implemented on those platforms. BUG=117197 TEST=Create a new profile. Make sure "Offset to save passwords" is enabled. Login in to gmail.com. Check that the one-click signi infobar is displayed, but not the save password infobar. Connect the profile to the account. log out of gmail and then back in. You should now see the save password infobar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129783

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/password_manager_delegate_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Fred, Please take a look. Thanks.
8 years, 9 months ago (2012-03-28 15:24:32 UTC) #1
akalin
LGTM
8 years, 9 months ago (2012-03-28 20:18:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/9873028/1
8 years, 8 months ago (2012-03-29 13:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/9873028/9002
8 years, 8 months ago (2012-03-29 16:50:17 UTC) #4
commit-bot: I haz the power
Try job failure for 9873028-9002 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 8 months ago (2012-03-29 21:31:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/9873028/9002
8 years, 8 months ago (2012-03-30 02:18:21 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-03-30 04:18:40 UTC) #7
Change committed as 129783

Powered by Google App Engine
This is Rietveld 408576698