Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 9867002: Fix link error when safe browsing is disabled. (Closed)

Created:
8 years, 9 months ago by Iain Merrick
Modified:
8 years, 9 months ago
Reviewers:
lain Merrick, jam, M-A Ruel
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix link error when safe browsing is disabled. This was breaking the 'chrome-linux-redux' bot, which compiles Chrome for Linux with the same flags we're using for the Android port. BUG=None TEST=Compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129463

Patch Set 1 #

Total comments: 2

Patch Set 2 : Minimised #ifdefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/memory_purger.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
lain Merrick
8 years, 9 months ago (2012-03-27 13:07:14 UTC) #1
M-A Ruel
I guess you wanted to run git try -b linux_redux ? :)
8 years, 9 months ago (2012-03-27 14:51:35 UTC) #2
lain Merrick
On 2012/03/27 14:51:35, Marc-Antoine Ruel wrote: > I guess you wanted to run git try ...
8 years, 9 months ago (2012-03-27 14:52:05 UTC) #3
lain Merrick
On 2012/03/27 14:52:05, lain Merrick wrote: > On 2012/03/27 14:51:35, Marc-Antoine Ruel wrote: > > ...
8 years, 9 months ago (2012-03-27 15:10:42 UTC) #4
M-A Ruel
lgtm but you'll want to get approval from an owner.
8 years, 9 months ago (2012-03-27 15:12:36 UTC) #5
lain Merrick
On 2012/03/27 15:12:36, Marc-Antoine Ruel wrote: > lgtm but you'll want to get approval from ...
8 years, 9 months ago (2012-03-27 15:13:28 UTC) #6
jam
http://codereview.chromium.org/9867002/diff/1/chrome/browser/memory_purger.cc File chrome/browser/memory_purger.cc (right): http://codereview.chromium.org/9867002/diff/1/chrome/browser/memory_purger.cc#newcode40 chrome/browser/memory_purger.cc:40: #if defined(ENABLE_SAFE_BROWSING) i think the first two ifdef's aren't ...
8 years, 9 months ago (2012-03-27 19:18:35 UTC) #7
Iain Merrick
http://codereview.chromium.org/9867002/diff/1/chrome/browser/memory_purger.cc File chrome/browser/memory_purger.cc (right): http://codereview.chromium.org/9867002/diff/1/chrome/browser/memory_purger.cc#newcode40 chrome/browser/memory_purger.cc:40: #if defined(ENABLE_SAFE_BROWSING) On 2012/03/27 19:18:35, John Abd-El-Malek wrote: > ...
8 years, 9 months ago (2012-03-28 10:25:42 UTC) #8
jam
lgtm
8 years, 9 months ago (2012-03-28 16:14:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/9867002/10001
8 years, 9 months ago (2012-03-28 16:15:39 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 19:38:32 UTC) #11
Change committed as 129463

Powered by Google App Engine
This is Rietveld 408576698