Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 9866043: Removed an unused instance variable that was not initialized in the constructor. (Closed)

Created:
8 years, 9 months ago by Kyle Horimoto
Modified:
8 years, 9 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removed an unused instance variable that was not initialized in the constructor. CID=103620 BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/nacl/nacl_validation_query.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Kyle Horimoto
I'm fairly sure that this instance variable is never used (Coverity and CS say so, ...
8 years, 9 months ago (2012-03-27 21:32:52 UTC) #1
sky
I'm not a good reviewer for this.
8 years, 9 months ago (2012-03-27 21:38:35 UTC) #2
Brad Chen (chromium)
[+ncbray] On Tue, Mar 27, 2012 at 2:38 PM, <sky@chromium.org> wrote: > I'm not a ...
8 years, 9 months ago (2012-03-27 21:45:53 UTC) #3
Brad Chen (chromium)
[+ncbray] On Tue, Mar 27, 2012 at 2:38 PM, <sky@chromium.org> wrote: > I'm not a ...
8 years, 9 months ago (2012-03-27 21:45:54 UTC) #4
Nick Bray
LGTM The CL was refactored during review and uses of this instance variable were eliminated ...
8 years, 9 months ago (2012-03-27 22:01:56 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-27 22:51:30 UTC) #6
Mark Seaborn
LGTM
8 years, 9 months ago (2012-03-27 23:03:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
8 years, 9 months ago (2012-03-27 23:03:52 UTC) #8
Kyle Horimoto
Brad, could you LGTM this? Thanks! On 2012/03/27 22:51:30, I haz the power (commit-bot) wrote: ...
8 years, 9 months ago (2012-03-27 23:06:16 UTC) #9
commit-bot: I haz the power
Try job failure for 9866043-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=14775 Step "update" is always ...
8 years, 9 months ago (2012-03-27 23:16:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
8 years, 9 months ago (2012-03-27 23:49:23 UTC) #11
commit-bot: I haz the power
Try job failure for 9866043-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=4753 Step "update" is always ...
8 years, 9 months ago (2012-03-28 00:00:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
8 years, 9 months ago (2012-03-28 00:36:26 UTC) #13
commit-bot: I haz the power
Try job failure for 9866043-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=4774 Step "update" is always ...
8 years, 9 months ago (2012-03-28 00:46:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
8 years, 9 months ago (2012-03-28 16:54:56 UTC) #15
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 18:54:21 UTC) #16
Change committed as 129453

Powered by Google App Engine
This is Rietveld 408576698