|
|
Created:
8 years, 9 months ago by Kyle Horimoto Modified:
8 years, 9 months ago CC:
chromium-reviews, native-client-reviews_googlegroups.com Base URL:
http://git.chromium.org/chromium/src.git@master Visibility:
Public. |
DescriptionRemoved an unused instance variable that was not initialized in the constructor.
CID=103620
BUG=NONE
TEST=NONE
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129453
Patch Set 1 #
Messages
Total messages: 16 (0 generated)
I'm fairly sure that this instance variable is never used (Coverity and CS say so, at least), but I wanted to make sure that it is okay to remove it.
I'm not a good reviewer for this.
[+ncbray] On Tue, Mar 27, 2012 at 2:38 PM, <sky@chromium.org> wrote: > I'm not a good reviewer for this. > > https://chromiumcodereview.**appspot.com/9866043/<https://chromiumcodereview.... > > > -- > You received this message because you are subscribed to the Google Groups > "Native-Client-Reviews" group. > To post to this group, send email to native-client-reviews@** > googlegroups.com <native-client-reviews@googlegroups.com>. > To unsubscribe from this group, send email to native-client-reviews+** > unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups... > . > For more options, visit this group at http://groups.google.com/** > group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en> > . > > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To post to this group, send email to native-client-reviews@googlegroups.com. To unsubscribe from this group, send email to native-client-reviews+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/native-client-reviews?hl=en.
[+ncbray] On Tue, Mar 27, 2012 at 2:38 PM, <sky@chromium.org> wrote: > I'm not a good reviewer for this. > > https://chromiumcodereview.**appspot.com/9866043/<https://chromiumcodereview.... > > > -- > You received this message because you are subscribed to the Google Groups > "Native-Client-Reviews" group. > To post to this group, send email to native-client-reviews@** > googlegroups.com <native-client-reviews@googlegroups.com>. > To unsubscribe from this group, send email to native-client-reviews+** > unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups... > . > For more options, visit this group at http://groups.google.com/** > group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en> > . > >
LGTM The CL was refactored during review and uses of this instance variable were eliminated before the CL was committed. I did not notice it lingering in the header file. Thanks. Note that I am not a full Chromium committer, and the CQ may give you grief w/o someone else rubber stamping this.
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
Brad, could you LGTM this? Thanks! On 2012/03/27 22:51:30, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer or > a lowly provisional committer, _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files.
Try job failure for 9866043-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu... Step "update" is always a major failure. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
Try job failure for 9866043-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number... Step "update" is always a major failure. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
Try job failure for 9866043-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number... Step "update" is always a major failure. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9866043/1
Change committed as 129453 |