Issue 9864056: chromeos: Send callback also on keyup and click when selecting language/network in OOBE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9864056: chromeos: Send callback also on keyup and click when selecting language/network in OOBE (Closed)

Created:
8 years, 9 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Send callback also on keyup and click when selecting language/network in OOBE BUG=chromium-os:25498 TEST=On OOBE, select language by mouse or keyboard (open the list by pressing enter, select with arrow keys, commit the selection with enter). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129584

Patch Set 1 : _ #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	chrome/browser/resources/chromeos/login/oobe.js	View		1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9864056/2001

8 years, 9 months ago (2012-03-28 20:51:59 UTC) #3

commit-bot: I haz the power

Try job failure for 9864056-2001 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 9 months ago (2012-03-29 00:21:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9864056/2001

8 years, 8 months ago (2012-03-29 03:22:09 UTC) #5

Change committed as 129584

Expand Messages | Collapse Messages