Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 9864019: Fix includes for sync internals search UI (Closed)

Created:
8 years, 9 months ago by rlarocque
Modified:
8 years, 9 months ago
Reviewers:
akalin
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix includes for sync internals search UI It looks like the changes made in r124187 accidentally broke the search UI on the chrome://sync page. This commit updates some includes to un-break search functionality. BUG=120334 TEST=Load search tab on chrome://sync, verify that search returns results. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/sync_internals/sync_index.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rlarocque
Please review. I'll admit I don't know what I'm doing here. I'm not familiar with ...
8 years, 9 months ago (2012-03-27 01:28:48 UTC) #1
akalin
LGTM On 2012/03/27 01:28:48, rlarocque wrote: > Please review. > > I'll admit I don't ...
8 years, 9 months ago (2012-03-28 20:18:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/9864019/1
8 years, 9 months ago (2012-03-28 20:21:43 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 22:54:49 UTC) #4
Change committed as 129507

Powered by Google App Engine
This is Rietveld 408576698