Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 9863050: Checked the return values of function calls. (Closed)

Created:
8 years, 9 months ago by Kyle Horimoto
Modified:
8 years, 9 months ago
Reviewers:
keybuk, khorimoto, satorux1
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Checked the return values of function calls. CID=103653,103654,103655 BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M dbus/values_util.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Kyle Horimoto
8 years, 9 months ago (2012-03-27 21:27:07 UTC) #1
keybuk
lgtm
8 years, 9 months ago (2012-03-27 22:01:58 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-27 23:02:10 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-27 23:07:39 UTC) #4
Kyle Horimoto
satorux1, can you LGTM? Thanks! On 2012/03/27 23:02:10, I haz the power (commit-bot) wrote: > ...
8 years, 9 months ago (2012-03-27 23:07:50 UTC) #5
satorux1
LGTM. What's CID?
8 years, 9 months ago (2012-03-27 23:23:19 UTC) #6
khorimoto
Coverity Bug ID On Tue, Mar 27, 2012 at 4:23 PM, <satorux@chromium.org> wrote: > LGTM. ...
8 years, 9 months ago (2012-03-27 23:27:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9863050/1
8 years, 9 months ago (2012-03-27 23:49:15 UTC) #8
commit-bot: I haz the power
Try job failure for 9863050-1 (retry) on win_rel for step "installer_util_unittests". It's a second try, ...
8 years, 9 months ago (2012-03-28 02:16:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9863050/1
8 years, 9 months ago (2012-03-28 16:54:47 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 19:00:08 UTC) #11
Change committed as 129454

Powered by Google App Engine
This is Rietveld 408576698