Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Side by Side Diff: net/socket/client_socket_pool.cc

Issue 9861032: Close idle connections / SPDY sessions when needed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/client_socket_pool.h ('k') | net/socket/client_socket_pool_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/client_socket_pool.h" 5 #include "net/socket/client_socket_pool.h"
6 6
7 #include "base/debug/alias.h"
7 #include "base/logging.h" 8 #include "base/logging.h"
8 9
9 namespace { 10 namespace {
10 11
11 // The maximum duration, in seconds, to keep unused idle persistent sockets 12 // The maximum duration, in seconds, to keep unused idle persistent sockets
12 // alive. 13 // alive.
13 // TODO(ziadh): Change this timeout after getting histogram data on how long it 14 // TODO(ziadh): Change this timeout after getting histogram data on how long it
14 // should be. 15 // should be.
15 int g_unused_idle_socket_timeout_s = 10; 16 int g_unused_idle_socket_timeout_s = 10;
16 17
17 // The maximum duration, in seconds, to keep used idle persistent sockets alive. 18 // The maximum duration, in seconds, to keep used idle persistent sockets alive.
18 int g_used_idle_socket_timeout_s = 300; // 5 minutes 19 int g_used_idle_socket_timeout_s = 300; // 5 minutes
19 20
20 } // namespace 21 } // namespace
21 22
22 namespace net { 23 namespace net {
23 24
25 LayeredPool::LayeredPool() : magic_value_(ALIVE) {}
26
27 LayeredPool::~LayeredPool() {
28 CrashIfFreed();
29 magic_value_ = DEAD;
30 stack_trace_ = base::debug::StackTrace();
31 }
32
33 void LayeredPool::CrashIfFreed() {
34 if (magic_value_ != ALIVE) {
35 MagicValue magic_value = magic_value_;
36 base::debug::StackTrace deletion_callstack = stack_trace_;
37
38 base::debug::Alias(&magic_value);
39 base::debug::Alias(&deletion_callstack);
40
41 CHECK(false);
42 }
43 }
44
24 // static 45 // static
25 base::TimeDelta ClientSocketPool::unused_idle_socket_timeout() { 46 base::TimeDelta ClientSocketPool::unused_idle_socket_timeout() {
26 return base::TimeDelta::FromSeconds(g_unused_idle_socket_timeout_s); 47 return base::TimeDelta::FromSeconds(g_unused_idle_socket_timeout_s);
27 } 48 }
28 49
29 // static 50 // static
30 void ClientSocketPool::set_unused_idle_socket_timeout(base::TimeDelta timeout) { 51 void ClientSocketPool::set_unused_idle_socket_timeout(base::TimeDelta timeout) {
31 DCHECK_GT(timeout.InSeconds(), 0); 52 DCHECK_GT(timeout.InSeconds(), 0);
32 g_unused_idle_socket_timeout_s = timeout.InSeconds(); 53 g_unused_idle_socket_timeout_s = timeout.InSeconds();
33 } 54 }
34 55
35 // static 56 // static
36 base::TimeDelta ClientSocketPool::used_idle_socket_timeout() { 57 base::TimeDelta ClientSocketPool::used_idle_socket_timeout() {
37 return base::TimeDelta::FromSeconds(g_used_idle_socket_timeout_s); 58 return base::TimeDelta::FromSeconds(g_used_idle_socket_timeout_s);
38 } 59 }
39 60
40 // static 61 // static
41 void ClientSocketPool::set_used_idle_socket_timeout(base::TimeDelta timeout) { 62 void ClientSocketPool::set_used_idle_socket_timeout(base::TimeDelta timeout) {
42 DCHECK_GT(timeout.InSeconds(), 0); 63 DCHECK_GT(timeout.InSeconds(), 0);
43 g_used_idle_socket_timeout_s = timeout.InSeconds(); 64 g_used_idle_socket_timeout_s = timeout.InSeconds();
44 } 65 }
45 66
46 ClientSocketPool::ClientSocketPool() {} 67 ClientSocketPool::ClientSocketPool() {}
47 68
48 ClientSocketPool::~ClientSocketPool() {} 69 ClientSocketPool::~ClientSocketPool() {}
49 70
50 } // namespace net 71 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/client_socket_pool.h ('k') | net/socket/client_socket_pool_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698