Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: chrome/browser/chromeos/login/captive_portal_view.cc

Issue 9861015: [cros] Captive portal dialog fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clarify Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/captive_portal_window_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/captive_portal_view.cc
diff --git a/chrome/browser/chromeos/login/captive_portal_view.cc b/chrome/browser/chromeos/login/captive_portal_view.cc
index 8eebf16c3045723375613d2a57f330b4b4ea3299..c3860bbee0c3d947157c7ee45a215b921e2133ac 100644
--- a/chrome/browser/chromeos/login/captive_portal_view.cc
+++ b/chrome/browser/chromeos/login/captive_portal_view.cc
@@ -290,8 +290,11 @@ void CaptivePortalView::LoadingStateChanged(WebContents* source) {
bool is_loading = source->IsLoading();
UpdateReload(is_loading, false);
command_updater_->UpdateCommandEnabled(IDC_STOP, is_loading);
- if (!is_loading && !redirected_)
- proxy_->OnOriginalURLLoaded();
+ // TODO(nkostylev): Fix case of no connectivity, check HTTP code returned.
+ // Disable this heuristic as it has false positives.
+ // Relying on just flimflam portal check to close dialog is fine.
+ // if (!is_loading && !redirected_)
+ // proxy_->OnOriginalURLLoaded();
}
TabContentsWrapper* CaptivePortalView::GetTabContentsWrapper() const {
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/captive_portal_window_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698