Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 9857009: Consider redirects to about:blank as canceling and don't flag conflicts (Closed)

Created:
8 years, 9 months ago by battre
Modified:
8 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Consider redirects to about:blank as canceling and don't flag conflicts If one extension redirects a webrequest to a different URL (e.g. from http://foo.com to https://foo.com) and another extension redirects to about:blank, the latter wants to express that it intends to cancel the request. With this CL we give precedence to cancelling requests by redirecting to about:blank and don't flag them redirect conflicts. BUG=111700 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129117

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 1 2 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
battre
Hi Matt, please review this CL. I think this is the right thing to do ...
8 years, 9 months ago (2012-03-26 12:43:25 UTC) #1
Matt Perry
lgtm
8 years, 9 months ago (2012-03-26 18:54:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9857009/1003
8 years, 9 months ago (2012-03-26 19:47:35 UTC) #3
commit-bot: I haz the power
Try job failure for 9857009-1003 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-26 22:28:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9857009/1003
8 years, 9 months ago (2012-03-26 22:32:37 UTC) #5
battre
On 2012/03/26 22:28:40, I haz the power (commit-bot) wrote: > Try job failure for 9857009-1003 ...
8 years, 9 months ago (2012-03-26 22:33:24 UTC) #6
Matt Perry
On 2012/03/26 22:33:24, battre wrote: > On 2012/03/26 22:28:40, I haz the power (commit-bot) wrote: ...
8 years, 9 months ago (2012-03-26 22:34:29 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-27 03:07:32 UTC) #8
Change committed as 129117

Powered by Google App Engine
This is Rietveld 408576698