Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 9854045: Check default_container in FramePainter::UseSoloWindowHeader (Closed)

Created:
8 years, 9 months ago by stevenjb
Modified:
8 years, 9 months ago
Reviewers:
James Cook, Daniel Erat
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Check default_container in FramePainter::UseSoloWindowHeader I happened to catch this while debugging. BUG=120786 TEST=Crash does not show up (hard to repro) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129591

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/wm/frame_painter.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
+derat for OWNER
8 years, 9 months ago (2012-03-28 23:38:38 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/9854045/diff/1/ash/wm/frame_painter.cc File ash/wm/frame_painter.cc (right): http://codereview.chromium.org/9854045/diff/1/ash/wm/frame_painter.cc#newcode550 ash/wm/frame_painter.cc:550: return false; // Shutting down. please add a ...
8 years, 9 months ago (2012-03-28 23:58:30 UTC) #2
stevenjb
http://codereview.chromium.org/9854045/diff/1/ash/wm/frame_painter.cc File ash/wm/frame_painter.cc (right): http://codereview.chromium.org/9854045/diff/1/ash/wm/frame_painter.cc#newcode550 ash/wm/frame_painter.cc:550: return false; // Shutting down. On 2012/03/28 23:58:30, Daniel ...
8 years, 9 months ago (2012-03-29 00:44:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9854045/3001
8 years, 9 months ago (2012-03-29 01:54:38 UTC) #4
commit-bot: I haz the power
Try job failure for 9854045-3001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-29 05:09:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/9854045/3001
8 years, 9 months ago (2012-03-29 05:10:41 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-29 08:32:15 UTC) #7
Change committed as 129591

Powered by Google App Engine
This is Rietveld 408576698