Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9854040: Fix some grammatical errors in base/ (Closed)

Created:
8 years, 8 months ago by gavinp
Modified:
8 years, 8 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix some grammatical errors in base/ BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130117

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove the incorrect fix I made (three out of four ain't bad?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/json/json_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_string_conversions_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
gavinp
wdyt?
8 years, 8 months ago (2012-03-28 23:54:18 UTC) #1
gavinp
No rush here will, enjoy Paris. I have a few of these minor grammar nit ...
8 years, 8 months ago (2012-03-30 01:16:30 UTC) #2
willchan no longer on Chromium
lgtm
8 years, 8 months ago (2012-04-02 08:57:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/9854040/3001
8 years, 8 months ago (2012-04-02 08:57:49 UTC) #4
commit-bot: I haz the power
Change committed as 130117
8 years, 8 months ago (2012-04-02 10:35:46 UTC) #5
gavinp
Haha, I was going to manually commit this will all my other changes, just to ...
8 years, 8 months ago (2012-04-02 11:32:41 UTC) #6
willchan no longer on Chromium
8 years, 8 months ago (2012-04-02 11:42:28 UTC) #7
I figured it was early enough in the day that I could get a build cycle in
pretty quickly before things got busy :)

On Mon, Apr 2, 2012 at 1:32 PM, Gavin Peters (蓋文彼德斯) <gavinp@chromium.org>wrote:

> Haha, I was going to manually commit this will all my other changes, just
> to minimise build cycling around minor changes.  But you beat me to it!
>
> Thanks for the reviews!
>
>
> On Mon, Apr 2, 2012 at 6:35 AM, <commit-bot@chromium.org> wrote:
>
>> Change committed as 130117
>>
>>
http://codereview.chromium.**org/9854040/<http://codereview.chromium.org/9854...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698