Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: chrome/browser/chromeos/device_hierarchy_observer.h

Issue 9854025: Automatically remap Command key on an Apple keyboard to Control [part 2 of 2 - Chrome part] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win_aura fix Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/device_hierarchy_observer.h
diff --git a/chrome/browser/chromeos/device_hierarchy_observer.h b/chrome/browser/chromeos/device_hierarchy_observer.h
index 8b360af1f78d3b0b371293661e42cd63efe40622..70f2853ad8aaf7aa12e6175a3c5a39158f7dfa64 100644
--- a/chrome/browser/chromeos/device_hierarchy_observer.h
+++ b/chrome/browser/chromeos/device_hierarchy_observer.h
@@ -13,6 +13,14 @@ class DeviceHierarchyObserver {
public:
virtual void DeviceHierarchyChanged() = 0;
+ // Called when a new device (e.g. an external USB keyboard) is attached.
+ virtual void DeviceAdded(int device_id) = 0;
Daniel Erat 2012/03/27 16:19:35 do you also need a DeviceRemoved() method?
Daniel Erat 2012/03/31 01:24:08 Done.
+
+ // Called when a key either on a built-in keyboard or external one is pressed.
+ // |device_id| is the source of the key event which will be sent to the Chrome
+ // window shortly.
+ virtual void KeyPressedOrReleased(int device_id) = 0;
Daniel Erat 2012/03/27 16:19:35 nit: rename to DeviceKeyPressedOrReleased() so the
Daniel Erat 2012/03/31 01:24:08 Done.
+
protected:
virtual ~DeviceHierarchyObserver() {}
};

Powered by Google App Engine
This is Rietveld 408576698