Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9854015: Handle broken artwork icons in Chrome OS Media Player (Closed)

Created:
8 years, 9 months ago by Vladislav Kaznacheev
Modified:
8 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Handle broken artwork icons in Chrome OS Media Player BUG=chromium-os:28409 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128900

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/resources/file_manager/js/media/audio_player.js View 1 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vladislav Kaznacheev
Please review this small patch.
8 years, 9 months ago (2012-03-26 08:24:51 UTC) #1
dgozman
LGTM with nit https://chromiumcodereview.appspot.com/9854015/diff/1/chrome/browser/resources/file_manager/js/media/audio_player.js File chrome/browser/resources/file_manager/js/media/audio_player.js (right): https://chromiumcodereview.appspot.com/9854015/diff/1/chrome/browser/resources/file_manager/js/media/audio_player.js#newcode336 chrome/browser/resources/file_manager/js/media/audio_player.js:336: // Only display the image if ...
8 years, 9 months ago (2012-03-26 10:52:49 UTC) #2
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/9854015/diff/1/chrome/browser/resources/file_manager/js/media/audio_player.js File chrome/browser/resources/file_manager/js/media/audio_player.js (right): https://chromiumcodereview.appspot.com/9854015/diff/1/chrome/browser/resources/file_manager/js/media/audio_player.js#newcode336 chrome/browser/resources/file_manager/js/media/audio_player.js:336: // Only display the image if the thumbnail On ...
8 years, 9 months ago (2012-03-26 10:55:52 UTC) #3
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/9854015/diff/1/chrome/browser/resources/file_manager/js/media/audio_player.js File chrome/browser/resources/file_manager/js/media/audio_player.js (right): https://chromiumcodereview.appspot.com/9854015/diff/1/chrome/browser/resources/file_manager/js/media/audio_player.js#newcode336 chrome/browser/resources/file_manager/js/media/audio_player.js:336: // Only display the image if the thumbnail On ...
8 years, 9 months ago (2012-03-26 10:55:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9854015/3002
8 years, 9 months ago (2012-03-26 10:57:40 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 13:22:23 UTC) #6 
Change committed as 128900

Powered by Google App Engine
This is Rietveld 408576698