chrome/browser/ui/views/ash/screenshot_taker.cc - Issue 9854012: Close the screenshot flash effect before the screenshot task is actually executed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/screenshot_taker.cc

Issue 9854012: Close the screenshot flash effect before the screenshot task is actually executed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/ash/screenshot_taker.cc

diff --git a/chrome/browser/ui/views/ash/screenshot_taker.cc b/chrome/browser/ui/views/ash/screenshot_taker.cc

index 1f874f1be47b8e454461b54dbe81d69f0ef75a33..508f48ee15427f6a36c65972e0873b20ea069dd0 100644

--- a/chrome/browser/ui/views/ash/screenshot_taker.cc

+++ b/chrome/browser/ui/views/ash/screenshot_taker.cc

@@ -117,7 +117,9 @@ void ScreenshotTaker::HandleTakeScreenshot(aura::Window* window) {

void ScreenshotTaker::CloseVisualFeedbackLayer(const base::Closure& task) {

visual_feedback_layer_.reset();

- task.Run();

+ // We want to make the close of visual effect without waiting for the end of

Daniel Erat 2012/03/26 14:49:15 nit: "Hide the visual feedback immediately because

Jun Mukai 2012/03/26 15:09:31 Done.

+ // |task| because it may take long time.

+ MessageLoopForUI::current()->PostTask(FROM_HERE, task);

}

void ScreenshotTaker::DisplayVisualFeedback(const gfx::Rect& rect,

« no previous file with comments | « no previous file | no next file » | no next file with comments »