Have URL Modifications sent Regardless of Typed.

chrome/browser/history/history_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/history_backend.h"
 
 #include <list>
 #include <map>
 #include <set>
 #include <vector>
@@ skipping 827 matching lines @@
       if (visit_info.visit_time < first_recorded_time_)
         first_recorded_time_ = visit_info.visit_time;
     }
   }
 
   // Broadcast a notification for typed URLs that have been modified. This
   // will be picked up by the in-memory URL database on the main thread.
   //
   // TODO(brettw) bug 1140015: Add an "add page" notification so the history
   // views can keep in sync.
-  BroadcastNotifications(chrome::NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED,
+  BroadcastNotifications(chrome::NOTIFICATION_HISTORY_URLS_MODIFIED,
                          modified.release());
 
   ScheduleCommit();
 }
 
 bool HistoryBackend::IsExpiredVisitTime(const base::Time& time) {
   return time < expirer_.GetCurrentArchiveTime();
 }
 
 void HistoryBackend::SetPageTitle(const GURL& url,
@@ skipping 13 matching lines @@
     // This redirect chain should have the destination URL as the last item.
     DCHECK(!redirects->empty());
     DCHECK(redirects->back() == url);
   } else {
     // No redirect chain stored, make up one containing the URL we want so we
     // can use the same logic below.
     dummy_list.push_back(url);
     redirects = &dummy_list;
   }
 
-  bool typed_url_changed = false;
   URLRows changed_urls;

[Peter Kasting, 2012/04/10 02:18:57]

Nit: You can save copying the whole URLRows object with something like:

  scoped_ptr<URLsModifiedDetails> details(...);
  for (...) {
    ...;
    details->changed_urls.push_back(row);
  }

  if (!details->changed_urls.empty())
    BroadcastNotifications(..., details.release());

[mrossetti, 2012/04/11 19:38:55]

Sweet!

On 2012/04/10 02:18:57, Peter Kasting wrote:

   for (size_t i = 0; i < redirects->size(); i++) {
     URLRow row;
     URLID row_id = db_->GetRowForURL(redirects->at(i), &row);
     if (row_id && row.title() != title) {
       row.set_title(title);
       db_->UpdateURLRow(row_id, row);
+      row.set_id(row_id);

[sky, 2012/04/10 16:29:01]

Doesn't GetRowForURL set the id?

[mrossetti, 2012/04/11 19:38:55]

Yes. Removed.

On 2012/04/10 16:29:01, sky wrote:

       changed_urls.push_back(row);
-      if (row.typed_count() > 0)
-        typed_url_changed = true;
     }
   }
 
-  // Broadcast notifications for typed URLs that have changed. This will
-  // update the in-memory database.
-  //
-  // TODO(brettw) bug 1140020: Broadcast for all changes (not just typed),
-  // in which case some logic can be removed.
-  if (typed_url_changed) {
-    URLsModifiedDetails* modified =
-        new URLsModifiedDetails;
-    for (size_t i = 0; i < changed_urls.size(); i++) {
-      if (changed_urls[i].typed_count() > 0)
-        modified->changed_urls.push_back(changed_urls[i]);
-    }
-    BroadcastNotifications(chrome::NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED,
+  // Broadcast notifications for any URLs that have changed. This will
+  // update the in-memory database and the InMemoryURLIndex.
+  if (!changed_urls.empty()) {
+    URLsModifiedDetails* modified = new URLsModifiedDetails;
+    modified->changed_urls = changed_urls;
+    BroadcastNotifications(chrome::NOTIFICATION_HISTORY_URLS_MODIFIED,
                            modified);
   }
 
   // Update the full text index.
   if (text_database_.get())
     text_database_->AddPageTitle(url, title);
 
   // Only bother committing if things changed.
   if (!changed_urls.empty())
     ScheduleCommit();
@@ skipping 1533 matching lines @@
     return false;
 
   favicon->expired = (Time::Now() - last_updated) >
       TimeDelta::FromDays(kFaviconRefetchDays);
   favicon->known_icon = true;
   favicon->image_data = data;
   return true;
 }
 
 }  // namespace history